Skip to content

Clarify temporary PD lifecycle in pd-recover (#23011)#23018

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-23011-to-release-8.5
Jun 8, 2026
Merged

Clarify temporary PD lifecycle in pd-recover (#23011)#23018
ti-chi-bot[bot] merged 1 commit into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-23011-to-release-8.5

Conversation

@ti-chi-bot

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #23011

What is changed, added or deleted? (Required)

补充 pd-recover 从存活 PD 节点重建集群时的步骤依赖说明:

  • 第 2 步启动的 --force-new-cluster PD 是临时单节点 PD,需要保持运行,供第 3 步 pd-recover 连接。
  • 第 3 步需要另开终端窗口执行。
  • 第 4 步明确需要停止第 2 步的临时 PD,并不带 --force-new-cluster 正常重启。
  • 第 5 步明确在 PD 正常启动并提供服务后再扩容 PD 和启动其他组件。

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jun 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pd-recover.md documentation to clarify the steps for recovering a PD cluster, specifically adding instructions on managing the temporary single-node PD process. The review feedback focuses on improving readability and ensuring compliance with the style guide by recommending the use of the second person ('you'), active voice, and present tense.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pd-recover.md
Comment thread pd-recover.md
Comment thread pd-recover.md
@hfxsd

hfxsd commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

/approve

@ti-chi-bot

ti-chi-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jun 8, 2026
@ti-chi-bot ti-chi-bot Bot merged commit 985ef9d into pingcap:release-8.5 Jun 8, 2026
11 checks passed
@ti-chi-bot ti-chi-bot Bot deleted the cherry-pick-23011-to-release-8.5 branch June 8, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants