Skip to content

cloud: update limited SQL features for Premium#23012

Open
Oreoxmt wants to merge 1 commit into
pingcap:release-8.5from
Oreoxmt:cloud/update-limited-sql-features
Open

cloud: update limited SQL features for Premium#23012
Oreoxmt wants to merge 1 commit into
pingcap:release-8.5from
Oreoxmt:cloud/update-limited-sql-features

Conversation

@Oreoxmt
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt commented Jun 5, 2026

…9546)

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilin90 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 5, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the limited-sql-features.md file to document the SQL feature limitations and support status for the new TiDB Cloud Premium tier. The review feedback focuses on improving documentation clarity and technical accuracy, including correcting a table classification for metrics_schema, reducing repetition in the IMPORT INTO description, and simplifying the LOAD DATA INFILE entry by removing redundant phrasing.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

| `mysql` | `tidb` | Not supported [^4] | Not supported [^4] |
| Database | Table | TiDB Cloud Dedicated | TiDB Cloud Premium | {{{ .starter }}} and {{{ .essential }}} |
|:-|:-|:-|:-|:-|
| `metrics_schema` | All databases | / | Not supported | / |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In the Table column for the metrics_schema database, it should say All tables instead of All databases.

Suggested change
| `metrics_schema` | All databases | / | Not supported | / |
| `metrics_schema` | All tables | / | Not supported | / |
References
  1. Ensure technical accuracy and terminology consistency by correcting mistakes. (link)

| `CHANGE DRAINER` | Not supported [^7] | Not supported | Not supported [^7] |
| `CHANGE PUMP` | Not supported [^7] | Not supported | Not supported [^7] |
| `FLASHBACK CLUSTER` | Supported | Not supported | Not supported [^3] |
| `IMPORT INTO` | / | Blocks `IMPORT INTO` from a local file path. Blocks `IMPORT INTO` statements that use an S3 `EXTERNAL_ID`. | / |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

To avoid unnecessary repetition of the phrase Blocks IMPORT INTO, we can combine the two sentences into a single, more concise sentence.

Suggested change
| `IMPORT INTO` | / | Blocks `IMPORT INTO` from a local file path. Blocks `IMPORT INTO` statements that use an S3 `EXTERNAL_ID`. | / |
| `IMPORT INTO` | / | Blocks `IMPORT INTO` from a local file path and statements that use an S3 `EXTERNAL_ID`. | / |
References
  1. Avoid unnecessary words and repetition to improve clarity and readability. (link)

| `CHANGE PUMP` | Not supported [^7] | Not supported | Not supported [^7] |
| `FLASHBACK CLUSTER` | Supported | Not supported | Not supported [^3] |
| `IMPORT INTO` | / | Blocks `IMPORT INTO` from a local file path. Blocks `IMPORT INTO` statements that use an S3 `EXTERNAL_ID`. | / |
| `LOAD DATA INFILE` | Supports `LOAD DATA LOCAL INFILE`, and `LOAD DATA INFILE` from Amazon S3 or Google Cloud Storage | Blocks `LOAD DATA LOCAL INFILE` from a local file path. | Only supports `LOAD DATA LOCAL INFILE` |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Since LOAD DATA LOCAL INFILE by definition only loads files from the client's local file system, adding from a local file path is redundant. We can simplify this to Blocks LOAD DATA LOCAL INFILE.

Suggested change
| `LOAD DATA INFILE` | Supports `LOAD DATA LOCAL INFILE`, and `LOAD DATA INFILE` from Amazon S3 or Google Cloud Storage | Blocks `LOAD DATA LOCAL INFILE` from a local file path. | Only supports `LOAD DATA LOCAL INFILE` |
| `LOAD DATA INFILE` | Supports `LOAD DATA LOCAL INFILE`, and `LOAD DATA INFILE` from Amazon S3 or Google Cloud Storage | Blocks `LOAD DATA LOCAL INFILE`. | Only supports `LOAD DATA LOCAL INFILE` |
References
  1. Avoid unnecessary words and repetition to keep the documentation concise. (link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant