Update the scope of system-variable ”tidb_redact_log“ (#21513) #21629
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
contribution
|
@Frank945946 This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the documentation for the tidb_redact_log system variable. The primary change is narrowing its defined scope from allowing both session and global settings to only global settings. This ensures that the documentation accurately reflects the intended behavior and configuration options for this variable.
Highlights
- System Variable Scope Update: The documentation for the
tidb_redact_logsystem variable has been updated to reflect that its scope is now exclusivelyGLOBAL, removing theSESSIONscope option. This clarifies that the variable can only be configured at the global level.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to update the scope of the tidb_redact_log system variable from SESSION | GLOBAL to GLOBAL. However, the current changes have introduced merge conflict markers into the system-variables.md file. These markers must be removed to ensure the document can be rendered correctly. I have provided a specific suggestion to resolve this issue.
system-variables.md
Outdated
| <<<<<<< HEAD | ||
| </CustomContent> | ||
|
|
||
| - Scope: SESSION | GLOBAL | ||
| ======= | ||
| - Scope: GLOBAL | ||
| >>>>>>> ad5a4464e1 (Update the scope of system-variable ”tidb_redact_log“ (#21513)) |
There was a problem hiding this comment.
It appears that merge conflict markers have been committed to this file. These should be removed to resolve the conflict and ensure the document renders correctly.
| <<<<<<< HEAD | |
| </CustomContent> | |
| - Scope: SESSION | GLOBAL | |
| ======= | |
| - Scope: GLOBAL | |
| >>>>>>> ad5a4464e1 (Update the scope of system-variable ”tidb_redact_log“ (#21513)) | |
| </CustomContent> | |
| - Scope: GLOBAL |
lilin90
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #21513
First-time contributors' checklist
What is changed, added or deleted? (Required)
Updated the scope of
tidb_redact_logfrom "SESSION | GLOBAL" to "GLOBAL".Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?