-
Notifications
You must be signed in to change notification settings - Fork 702
cloud: add the feature availability info of TiDB Cloud Essential #21516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud: add the feature availability info of TiDB Cloud Essential #21516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @qiancai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the TiDB Cloud documentation to incorporate information about the new 'Essential' cluster tier, which is now publicly available on Alibaba Cloud. This comprehensive update ensures that all relevant sections, from feature descriptions and limitations to connection methods and CLI commands, accurately reflect the capabilities and usage of both 'Starter' and 'Essential' clusters. The goal is to provide clear and up-to-date guidance for users leveraging these new offerings.
Highlights
- Introduction of TiDB Cloud Essential Tier: I've introduced the new 'Essential' cluster tier into the TiDB Cloud documentation, detailing its enhanced capabilities, automatic scaling, high availability, and predictable pricing model. This new tier is designed for applications with growing workloads, providing flexibility and performance.
- Comprehensive Documentation Updates for Essential Tier: Across numerous documentation files, I've updated references that previously only mentioned 'Starter' clusters to now explicitly include 'Essential' clusters. This ensures consistency and accuracy for users interacting with both tiers.
- Feature Availability and Limitations Clarification: I've clarified the availability and limitations of various features, such as Data Service, Chat2Query API, full-text search, and third-party monitoring integrations, specifying their support for 'Starter' and 'Essential' clusters, particularly when hosted on AWS.
- CLI and Terraform Documentation Alignment: The CLI command references and Terraform resource documentation have been updated to reflect the inclusion of the 'Essential' tier, ensuring that programmatic interactions and infrastructure-as-code definitions are accurate.
- Data Management and Migration Updates: I've updated the backup/restore, import/export, and migration guides to ensure they correctly reference the 'Essential' tier, providing clear instructions for data management across all relevant cluster types.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation to include the new TiDB Cloud Essential tier alongside the Starter tier. The changes are consistent across multiple files, improving clarity and accuracy. I've provided a couple of minor suggestions for consistency and formatting. Overall, the changes are well-executed and align with the goal of the PR.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
7488fda
to
901f754
Compare
| Row-based storage (per GiB/month) | $0.24 | | ||
| Columnar storage (per GiB/month) | $0.06 | | ||
| Row-based storage with dual-layer encryption (per GiB/month) | $0.36 | | ||
| Columnar storage with dual-layer encryption (per GiB/month) | $0.09 | | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PS: the preceding changes are to align with #21516
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2e09b83
into
pingcap:feature/preview-starter
What is changed, added or deleted? (Required)
To support the public preview of TiDB Cloud Essential on Alibaba Cloud, this PR clarifies the availability info of TiDB Cloud Essential.
Note
This PR updated only those files inside the
./tidb-cloud
directory. For changes outside the./tidb-cloud
directory, see #21509.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?