tiflash: correct the default value of task_scheduler_active_set_soft_limit (#21137) #21149
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
ti-chi-bot
added
lgtm
requires-version-specific-changes
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily updates documentation related to TiFlash configuration and release notes. It corrects an inaccuracy in the documented default value for a TiFlash task scheduler parameter and updates links in older release notes to point to the documentation archive. This is an automated cherry-pick from another repository.
Highlights
- TiFlash Configuration Documentation Correction: Corrected the documented default value for the
task_scheduler_active_set_soft_limitparameter in the TiFlash configuration documentation (tiflash/tiflash-configuration.md). The documentation now accurately reflects the change in default value fromvcpu * 0.25(before v7.4.0) tovcpu * 2(from v7.4.0 onwards). - Release Notes Link Updates: Updated several internal links within the v7.4.0 release notes (
releases/release-7.4.0.md) to point to the documentation archive domain (docs-archive.pingcap.com) instead of the main documentation domain (docs.pingcap.com).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly updates the documentation for the default value of task_scheduler_active_set_soft_limit in TiFlash, reflecting the change made in v7.4.0. It also updates several links in the release-7.4.0.md file to point to docs-archive.pingcap.com, which is appropriate for an older release note.
The changes are clear and accurate. I've offered one minor stylistic suggestion for tiflash/tiflash-configuration.md to align the tense with the style guide when describing historical default values and to slightly improve conciseness. I also noted a point about terminology consistency for the author's consideration.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #21137
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
task_scheduler_active_set_soft_limitdocs-cn#20474Do your changes match any of the following descriptions?