update CM part for Azure public review #20841
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @qqqdan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the documentation for TiDB Cloud, specifically focusing on Azure support and clarifying the cooldown periods for changes on AWS. The changes involve modifications to scale-tidb-cluster.md and upgrade-tidb-cluster.md to reflect these updates.
Highlights
- Azure Support: The documentation is updated to include Azure as a supported cloud provider for TiDB Cloud.
- Cooldown Period Clarification: The cooldown period for storage and vCPU/RAM changes on AWS is clarified, and Azure is also mentioned to have a cooldown period for storage changes.
- Storage Downgrade Warning: The warning message about storage capacity downgrade is updated to include Azure, stating that AWS, Google Cloud, and Azure do not allow in-place storage capacity downgrade for running clusters.
Changelog
- tidb-cloud/scale-tidb-cluster.md
- Updated the warning message to include Azure as a cloud provider that does not allow in-place storage capacity downgrade.
- Clarified that both AWS and Azure have a cooldown period after changing storage or vCPU/RAM.
- tidb-cloud/upgrade-tidb-cluster.md
- Added Azure to the list of supported cloud providers when submitting an upgrade request.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ti-chi-bot
bot
added
missing-translation-status
There was a problem hiding this comment.
Code Review
The pull request updates the TiDB Cloud documentation to reflect the addition of Azure as a supported cloud provider for scaling and upgrading TiDB clusters. The changes include updating the documentation to reflect the addition of Azure as a supported cloud provider for scaling and upgrading TiDB clusters. The changes are straightforward and seem correct.
Summary of Findings
- In-place storage capacity downgrade: The documentation has been updated to reflect that Azure, like AWS and Google Cloud, does not allow in-place storage capacity downgrade for running clusters.
- Cooldown period for storage changes: The documentation has been updated to reflect that Azure, like AWS, has a cooldown period for storage changes.
- Cloud provider list: The documentation has been updated to include Azure in the list of supported cloud providers for upgrade requests.
Merge Readiness
The changes in this pull request are straightforward and address the addition of Azure as a supported cloud provider. The updates to the documentation seem accurate and consistent with the changes. I am unable to directly approve the pull request, and users should have others review and approve this code before merging. Given the low number and low severity of the comments, this pull request is ready to be merged.
[LGTM Timeline notifier]Timeline:
|
qiancai
added
translation/no-need
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@qiancai: Your lgtm message is repeated, so it is ignored. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?