Add tidb index usage limitation for valid stats #20833
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @YangKeao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds a limitation to the tidb index usage documentation, aligning the description with the "index-advisor.md" file. Specifically, it clarifies that index usage is only recorded if the table has valid statistics. This change affects the information-schema/information-schema-tidb-index-usage.md file.
Highlights
- Documentation Update: Adds a note to the documentation clarifying that index usage is only recorded if the table has valid statistics.
- Consistency: Ensures the documentation is consistent with the information provided in
index-advisor.md.
Changelog
- information-schema/information-schema-tidb-index-usage.md
- Added a statement indicating that index usage is only recorded if the table has valid statistics.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ti-chi-bot
bot
added
missing-translation-status
There was a problem hiding this comment.
Code Review
The pull request adds a crucial limitation to the documentation regarding the CLUSTER_TIDB_INDEX_USAGE table. The addition clarifies that index usage is only recorded if the table has valid statistics, aligning the documentation with the actual behavior of TiDB. The change is well-described and addresses a potential point of confusion for users.
Summary of Findings
- Completeness: The added limitation is clear and concise, effectively communicating the delay and reset behavior of the
CLUSTER_TIDB_INDEX_USAGEdata, as well as the dependency on valid statistics. The description aligns well with the existing documentation and the referencedindex-advisor.md.
Merge Readiness
The pull request is ready for merging. The added limitation is clear, concise, and aligned with the existing documentation. There are no identified issues that would prevent merging. However, I am unable to directly approve the pull request, and it should be reviewed and approved by other reviewers before merging.
|
@lcwangchao: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
qiancai
added
needs-cherry-pick-release-8.1
| @@ -101,6 +101,7 @@ The output is as follows: | |||
|
|
|||
| - The data in the `TIDB_INDEX_USAGE` table might be delayed by up to 5 minutes. | |||
| - After TiDB restarts, the data in the `TIDB_INDEX_USAGE` table is cleared. | |||
| - Index usage is only recorded if the table has valid statistics. | |||
There was a problem hiding this comment.
| - Index usage is only recorded if the table has valid statistics. | |
| - TiDB records index usage for a table only when the table has valid statistics. |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: Yang Keao <[email protected]>
YangKeao
force-pushed
the
add-tidb-usage-limitation
branch
from
bea518c to
4457844
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Add a limitation to the tidb usage limitation. The description is aligned with the "index-advisor.md":
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?