Update pad attribute where needed #20823
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @dveeden, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the pad_attribute column in the output of SHOW COLLATION and the information_schema.COLLATIONS table. The changes involve modifying the output of SQL queries in the documentation to include the PAD_ATTRIBUTE column, which indicates whether trailing spaces are significant for comparisons. The documentation is updated to reflect this change, providing clarity on the meaning of the PAD_ATTRIBUTE column.
Highlights
- Pad Attribute: The pull request introduces the
PAD_ATTRIBUTEcolumn to the output ofSHOW COLLATIONandinformation_schema.COLLATIONS, indicating whether trailing spaces are significant in comparisons. - Documentation Update: The documentation is updated to reflect the addition of the
PAD_ATTRIBUTEcolumn, explaining its meaning and usage. - Compatibility: The changes are made for compatibility with MySQL.
Changelog
Click here to see the changelog
- character-set-and-collation.md
- Modified the output of the
SHOW COLLATIONexample to include thePad_attributecolumn. - Updated the values for the
Pad_attributecolumn to reflect the correct padding behavior for each collation.
- Modified the output of the
- information-schema/information-schema-collations.md
- Removed unnecessary
copyableblock. - Modified the output of the
DESC collationsexample to include thePAD_ATTRIBUTEcolumn. - Modified the output of the
SELECT * FROM collations WHERE character_set_name='utf8mb4'example to include thePAD_ATTRIBUTEcolumn. - Added a description of the
PAD_ATTRIBUTEcolumn to the table description.
- Removed unnecessary
- sql-statements/sql-statement-show-collation.md
- Modified the output of the
SHOW COLLATIONexample to include thePad_attributecolumn. - Updated the values for the
Pad_attributecolumn to reflect the correct padding behavior for each collation.
- Modified the output of the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ti-chi-bot
bot
added
missing-translation-status
There was a problem hiding this comment.
Code Review
The pull request updates the pad attribute in several documentation files related to character sets and collations in TiDB. The changes primarily involve adding the Pad_attribute column to the output examples of SHOW COLLATION and information_schema.collations queries, along with a brief description of this attribute. Overall, the changes seem straightforward and improve the documentation by providing more complete information about collations.
Merge Readiness
The pull request appears to be well-structured and addresses the stated objective of updating the pad attribute where needed. The changes enhance the documentation by providing more comprehensive information on collation attributes. I am unable to approve this pull request, and recommend that others review and approve this code before merging. Given the absence of critical or high severity issues, the pull request seems to be in good shape for merging after addressing the comments.
[LGTM Timeline notifier]Timeline:
|
Co-authored-by: Grace Cai <[email protected]>
qiancai
added
translation/doing
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
pingcap/tidb#54250
Do your changes match any of the following descriptions?