Skip to content

BR: update gcp_v2 storage#21469

Open
JoyC-dev wants to merge 1 commit intopingcap:masterfrom
JoyC-dev:gcp_v2_impl
Open

BR: update gcp_v2 storage#21469
JoyC-dev wants to merge 1 commit intopingcap:masterfrom
JoyC-dev:gcp_v2_impl

Conversation

@JoyC-dev
Copy link
Copy Markdown

@JoyC-dev JoyC-dev commented Mar 27, 2026 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

tikv/tikv#19315

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Mar 27, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilin90 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 27, 2026
@pingcap-cla-assistant
Copy link
Copy Markdown

pingcap-cla-assistant bot commented Mar 27, 2026 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

v01dstar
v01dstar reviewed Mar 27, 2026
View reviewed changes
br/backup-and-restore-storages.md
- 方式一：显式指定 `credentials-file`

- 如果 `credentials-file` 指向 Service Account JSON，则 BR 和 TiKV 按该凭据访问 GCS。
- 如果 TiKV 使用 `gcp_v2` 外部存储后端，则 `credentials-file` 也可以指向 Google Cloud WIF 使用的 `external_account` JSON。
Copy link
Copy Markdown
Contributor

@v01dstar v01dstar Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要加上版本信息吧。比如 “8.5.7 之后，TiKV 默认使用 gcp_v2, xxxx"

Copy link
Copy Markdown
Contributor

@v01dstar v01dstar Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为我们目前 LTS 是 8.5。合进 master ，但不在 8.5 有可能 confuse 客户。所以这个 doc 一定是等对应 PR 进了 8.5 被 release 了之后再合

@v01dstar
Copy link
Copy Markdown
Contributor

v01dstar commented Mar 27, 2026

/hold
等 tikv/tikv#19315 被cherrypick 到8.5再合并这个

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@v01dstar v01dstar v01dstar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoyC-dev @v01dstar