Skip to content

tidb: Remove warning about experimental feature for collecting predicate columns and update default value for tidb_enable_collect_predicate_columns #19495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Jan 8, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

tidb: Remove warning about experimental feature for collecting predicate columns and update default value for tidb_enable_collect_predicate_columns

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

…ate columns and update default value for tidb_enable_collect_predicate_columns
@Oreoxmt Oreoxmt added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-release-8.3 needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Jan 8, 2025
@Oreoxmt Oreoxmt self-assigned this Jan 8, 2025
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Jan 8, 2025

/cc @Rustin170506

@ti-chi-bot ti-chi-bot bot requested a review from 0xPoe January 8, 2025 07:53
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2025
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Mar 24, 2025

@Rustin170506 PTAL

@qiancai
Copy link
Collaborator

qiancai commented Jul 11, 2025

Removed the needs-cherry-pick-release-8.3 label because the v8.3 docs have been archived at https://docs-archive.pingcap.com/zh/tidb/v8.3 and will no longer receive new updates.

@qiancai
Copy link
Collaborator

qiancai commented Jul 11, 2025

Removed the needs-cherry-pick-release-8.4 label because the v8.4 docs have been archived at https://docs-archive.pingcap.com/zh/tidb/v8.4 and will no longer receive new updates.

Copy link

ti-chi-bot bot commented Jul 31, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-31 07:05:10.726210254 +0000 UTC m=+161323.411480470: ☑️ agreed by qiancai.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 31, 2025
Copy link
Member

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

Copy link

ti-chi-bot bot commented Jul 31, 2025

@0xPoe: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Thanks! :shipit:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Oreoxmt Oreoxmt added the lgtm label Jul 31, 2025
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Jul 31, 2025

/approve

Copy link

ti-chi-bot bot commented Jul 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 31, 2025
@ti-chi-bot ti-chi-bot bot merged commit c405a78 into pingcap:master Jul 31, 2025
6 of 7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20711.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants