Improve readability of large numbers in user interface

pine-vm · Aug 15, 2022 · 55fbd91 · 55fbd91
1 parent b26b342
commit 55fbd91
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/implement/elm-fullstack/Pine/CommandLineInterface.cs b/implement/elm-fullstack/Pine/CommandLineInterface.cs
@@ -1,7 +1,18 @@
-namespace Pine;
+using System.Globalization;
+
+namespace Pine;
 
 public class CommandLineInterface
 {
     static public string FormatIntegerForDisplay(long integer) =>
-        integer.ToString("### ### ### ### ### ### ##0").Trim();
+        FormatIntegerForDisplay(integer, '_');
+
+    static public string FormatIntegerForDisplay(long integer, char thousandsSeparator) =>
+        integer.ToString("N",
+            new NumberFormatInfo
+            {
+                NumberGroupSizes = new[] { 3, 3, 3, 3, 3, 3 },
+                NumberGroupSeparator = thousandsSeparator.ToString(),
+                NumberDecimalDigits = 0
+            });
 }
diff --git a/implement/elm-fullstack/Program.cs b/implement/elm-fullstack/Program.cs
@@ -1115,7 +1115,9 @@ static public IEnumerable<string> DescribeCompositionForHumans(
         {
             var blobs = composition.EnumerateBlobsTransitive().ToImmutableList();
 
-            yield return "a tree containing " + blobs.Count + " blobs with an aggregate size of " + blobs.Sum(blob => (long)blob.blobContent.Length) + " bytes.";
+            yield return
+                "a tree containing " + blobs.Count + " blobs with an aggregate size of " +
+                CommandLineInterface.FormatIntegerForDisplay(blobs.Sum(blob => (long)blob.blobContent.Length)) + " bytes.";
 
             if (listBlobs)
                 yield return