[Improvement]: Allow filter definition's page limit to be int as well

[dolmit-tanel-paaro]

Resolves #195

[fashxp]

nice, do we need a migration there for existing data?

[dolmit-tanel-paaro]

No, existing decimal values will get converted to integers, meaning nothing really happens to the values.
But everyone will have to update their FilterDefinition class definition to support the new return typehint.

[fashxp]

But everyone will have to update their FilterDefinition class definition to support the new return typehint.

That's also what I meant with migration :-). At least we will need an upgrade note. But I'm not sure though, how a migration path could look like?

Automatically overwriting the class definition is dangerous, because there might custom adaption to that class definition.
Before the upgrade you won't be able to manually change the typehint, because then they won't match to the old abstract classes anymore and break the system.
After a composer update the system also will be broken for the same reason - the typehints do not match to the abstract classes anymore.

Any ideas?

[dolmit-tanel-paaro]

Yeah, this situation is just like the one we faced when we migrated from Pimcore 6 to Pimcore X. Everything was broken because of return typehints because they were made mandatory.

Back then we solved it by upgrading to Pimcore X and then manually go over our class definitions and update return typehints manually.

The migration plan:

• update the package
• fix the issue(s) manually
• run composer again

[fashxp]

Hmm, we could do a two step process.
for now, we just change return-type of interface to float|int|null, which won't break any existing installations and also does not require any changes on existing data - but allows safely to convert the data over time.

And then with next major, we could switch to pure int.

The change in src/Resources/install/class_sources/class_FilterDefinition_export.json we could keep, as it just reflects for new installations.

[dolmit-tanel-paaro]

Yeah, that's a good approach. I'll make the changes.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[dolmit-tanel-paaro]

Updated abstract class, allowing float and int values.
Added todo for next major.
diff

[fashxp]

thx very much