-
Notifications
You must be signed in to change notification settings - Fork 123
Sort object bricks by name #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mjanser
wants to merge
2
commits into
pimcore:2.x
Choose a base branch
from
mjanser:patch-1
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
jdreesen
reviewed
Sep 9, 2025
jdreesen
reviewed
Sep 9, 2025
Co-authored-by: Jacob Dreesen <[email protected]>
|
This is what I did in the meantime. It additionally sorts the object bricks by the translated title. <?php
declare(strict_types=1);
namespace App\Pimcore\Objectbrick;
use Pimcore\Bundle\AdminBundle\Event\AdminEvents;
use Symfony\Component\EventDispatcher\Attribute\AsEventListener;
use Symfony\Component\EventDispatcher\GenericEvent;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Contracts\Translation\TranslatorInterface;
final readonly class ObjectbrickSorter
{
public function __construct(
private RequestStack $requestStack,
private TranslatorInterface $translator,
) {
}
#[AsEventListener(AdminEvents::CLASS_OBJECTBRICK_LIST_PRE_SEND_DATA)]
public function sortObjectbricks(GenericEvent $event): void
{
$language = 'en';
$request = $this->requestStack->getCurrentRequest();
if (null !== $request) {
$language = $request->getLocale();
}
$definitions = $event->getArgument('list');
if (is_array($definitions)) {
usort($definitions, static function (mixed $a, mixed $b): int {
if (! is_array($a) || ! is_array($b)) {
return 0;
}
if (array_key_exists('children', $a) && ! array_key_exists('children', $b)) {
return 1;
}
if (array_key_exists('children', $b) && ! array_key_exists('children', $a)) {
return -1;
}
return $a['text'] <=> $b['text'];
});
if (null !== $event->getArgument('objectId')) {
// Sort children by their translated title when displayed on objects
foreach ($definitions as &$definition) {
if (is_array($definition) && array_key_exists('children', $definition) && is_array($definition['children'])) {
usort($definition['children'], function (mixed $a, mixed $b) use ($language): int {
if (! is_array($a) || ! array_key_exists('title', $a) || ! is_string($a['title']) || ! is_array($b) || ! array_key_exists('title', $b) || ! is_string($b['title'])) {
return 0;
}
$titleA = $this->translator->trans($a['title'], domain: 'admin', locale: $language);
$titleB = $this->translator->trans($b['title'], domain: 'admin', locale: $language);
return $titleA <=> $titleB;
});
}
}
}
$event->setArgument('list', $definitions);
}
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.