Skip to content

Use Attribute instead of Annotation to define route. Add pimcore_admin_element_islocked #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2025
Merged

Use Attribute instead of Annotation to define route. Add pimcore_admin_element_islocked #1014

merged 5 commits into from
Oct 10, 2025

Conversation

muratbinerbay
Copy link
Contributor

@muratbinerbay muratbinerbay commented Sep 30, 2025 •
edited
Loading

Pimcore 12.2.1 with admin-ui-classic-bundle 2.2.0 fails to check if an element is locked because the route pimcore_admin_element_islocked was never defined in ElementController:

image

As Symfony Annotation is deprecated the route definition for lockElementAction does not work

Related to #724

@muratbinerbay
Copy link
Contributor Author

Had to call activeTab.initialConfig.document.reload() / activeTab.initialConfig.object.reload() because the consecutive calls for close & open was leading to this error:

Screenshot 2025-09-30 at 1 45 06 pm

@kingjia90 kingjia90 added this to the 2.2.1 milestone Oct 8, 2025
@kingjia90 kingjia90 self-assigned this Oct 8, 2025
kingjia90
kingjia90 reviewed Oct 8, 2025
View reviewed changes
Copy link
Contributor

@kingjia90 kingjia90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

Indeed it wasn't working properly

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kingjia90 kingjia90 merged commit e55ae1f into pimcore:2.x Oct 10, 2025
12 checks passed
@kingjia90 kingjia90 added the Bug label Oct 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2025
@muratbinerbay muratbinerbay deleted the fix-is-locked-bug branch October 13, 2025 07:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kingjia90 kingjia90 kingjia90 left review comments

Assignees

@kingjia90 kingjia90

Labels

Bug Pimcore:Priority

Projects

None yet

Milestone

2.2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@muratbinerbay @kingjia90