Damage Calc Feature Proposal: Bulk and Absolute-Power Calculation #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Pikalytics / @GriffinLedingham ! Big fan of the site and had an idea for the damage calc that I think would help players.
I've always disliked that there hasn't been an absolute value calculated for Pokémon bulk and move powers. Instead, the values are hidden by being split up between HP and defense stats for bulk, and move power, attack stat, typing, etc. for absolute power.
My feature for the damage calculator is to calculate a visible value for these properties and to put them on the same scale (eg: a Pokémon that can inflict 100 absolute damage will KO a Pokémon with 100 bulk). This could help players deal with situations that they haven't planned calcs for by giving them a more concrete sense of how strong their moves are and how bulky an opponent is.
The pull request I am submitting shows the feature working for the most part. Abs-power is calculated and shown next to each move's percentage damage done and bulk is shown next to the Pokémon's defense and sp-defense stats.
Some known issues: Conditions such as screens, friend guard, and helping hand affect both move power and bulk values when they should only affect one or the other (mainly due to the field object being uneditable). Adding an abs-power field to the central move readout would involve altering the 'results' object and accompanying functions and I'm not sure if changing them might break compatibility with the upstream calculator source code.
Would be happy to answer any questions about how the values are derived. Let me know if you think this is a feature worth working on.