Skip to content

Removed removeCommentsRx #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed removeCommentsRx #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,12 @@
(function(define) {
define( function() {

var defaultModuleRegex, defaultSpecRegex, defaultWireName, replaceIdsRegex, removeCommentsRx, specCache;
var defaultModuleRegex, defaultSpecRegex, defaultWireName, replaceIdsRegex, specCache;
// default dependency regex
defaultWireName = 'wire';
defaultModuleRegex = /(\.module|\.create|\$plugins\[\])$/;
defaultSpecRegex = /(\.wire|\.spec)$/;
replaceIdsRegex = /(define)\s*\(\s*(?:\s*["']([^"']*)["']\s*,)?(?:\s*\[([^\]]*)\]\s*,)?/;
removeCommentsRx = /\/\*[\s\S]*?\*\/|\/\/.*?[\n\r]/g;
specCache = {};

// Using special require.nodeRequire, something added by r.js.
Expand Down Expand Up @@ -197,7 +196,7 @@

function injectIds (moduleText, absId, moduleIds) {
// note: replaceIdsRegex removes commas, parens, and brackets
return moduleText.replace(removeCommentsRx, '').replace(replaceIdsRegex, function (m, def, mid, depIds) {
return moduleText.replace(replaceIdsRegex, function (m, def, mid, depIds) {

// merge deps, but not args since they're not referenced in module
if (depIds) {
Expand Down