Implement Progressive Sword in logic #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike8699
force-pushed
the
progressive-sword-logic
branch
from
d7863a5 to
257c2c4
Compare
|
@Redriel57 WDYT, do you see any issues with doing it this way? |
|
I agree on most of it, I just think that non-progressive swords could be a setting too. |
Good point. for now I'll merge this, and I filed #335 to make a follow up that allows for non-progressive swords/other items. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the oshus sword, phantom sword blade, and phantom sword as a single "Progressive Sword". I introduced some macros to allow, for example, "Phantom Sword" to still be used as a requirement instead of having to require 3 progressive swords.