Optimize compiler filesystem caching #16
Conversation
There was a problem hiding this comment.
Mostly nitpicking because a lot of these changes are functionally not doing anything and I assume they were at some point introduced during debugging.
The only thing that I'd ask you to look into would be if this would affect watch mode, and if it does we probably need to make the caching configurable.
| const filenames = Object.keys(files); | ||
| this.compilerHost.setScriptFileNames(filenames); |
There was a problem hiding this comment.
I think there's a bunch of these going on for logging purposes - could you undo them so we have the diff a little bit smaller?
| const result = | ||
| !!virtualFiles[normalize(fileName)] || ts.sys.fileExists(fileName); | ||
| return result; |
There was a problem hiding this comment.
Also pulled apart for logging purposes I guess?
| if (normalized in cachedFiles) { | ||
| const cacheResult = cachedFiles[fileName]; | ||
|
|
||
| if (cacheResult) { | ||
| return cacheResult; | ||
| } | ||
| } | ||
|
|
||
| const contents = ts.sys.readFile(fileName); | ||
|
|
||
| if (contents) { | ||
| cachedFiles[normalized] = contents; | ||
| } |
There was a problem hiding this comment.
Did you verify that this doesn't cause problems in watch mode?
If it does, we might need a flag to swap behaviours here.
| }, | ||
| resolveModuleNames(moduleNames, containingFile) { | ||
| return moduleNames.map((moduleName) => { | ||
| const mappedModules = moduleNames.map((moduleName) => { |
There was a problem hiding this comment.
This could also stay a direct return and was only pulled apart for logging I think?
| const resolvedModule = ts.resolveModuleName( | ||
| newModuleName, | ||
| containingFile, | ||
| compilerOptions, | ||
| this | ||
| ).resolvedModule; | ||
|
|
||
| return resolvedModule; |
There was a problem hiding this comment.
| const resolvedModule = ts.resolveModuleName( | |
| newModuleName, | |
| containingFile, | |
| compilerOptions, | |
| this | |
| ).resolvedModule; | |
| return resolvedModule; | |
| return ts.resolveModuleName( | |
| newModuleName, | |
| containingFile, | |
| compilerOptions, | |
| this | |
| ).resolvedModule; |
|
|
||
| let cachedFiles: Record<string, string | undefined> = {}; | ||
|
|
||
| const host: ModifiedCompilerHost = { |
There was a problem hiding this comment.
I think this could also stay a direct return?
2 participants
This PR: