Add Grouped Error Formatter#4002
Open
FeBe95 wants to merge 7 commits into
Open
Conversation
Contributor
|
How is this helpful, should't the grouping be done on filename basis? The reason is many different errors are related, thus errors for LoC close to each other should be reported together. |
Contributor
Author
|
We introduced PHPStan to our codebase a few weeks ago. We started with level 0 and added all existing errors to the baseline file. Then our workflow is as follows:
We have found it much easier to do research on one specific error type at a time. Often, you can find an answer right away on how to fix the underlying bugs, and then apply it to all similar ones. |
# Conflicts: # conf/config.neon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new error formatter that groups all errors by their identifier. Groups are sorted in descending order based on the number of occurrences. The output format is a hybrid of the raw and table error formatters.
All error lines are clickable for easy code navigation. As with the table error formatter, the
file:lineformat can be customized via theeditorUrlandeditorUrlTitleparameters.Usage
Use Case
This formatter is particularly useful when working with a large number of errors, for example, when introducing PHPStan to an existing codebase. Grouping by error identifier instead of by file helps speed up the review and fixing process.
Example Output
Screenshot