Fix count() regression
#3895
Merged
Fix count() regression
#3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
//cc @herndlm |
|
Wow, you beat me to it it seems. I didn't even have time to get to a computer yet. Thx! But I was also not expecting for the fix to be this tbh 🤔 Maybe you can rename the variable too :) |
|
I guess we are narrowing a NonEmptyArray with a count(0) down the line. but I could not pinpoint where exactly. |
|
Thank you! I'll report back if testing on real-world projects finds more problems. Otherwise I'll be able to release 2.1.9. |
|
@ondrejmirtes just give me a minute, I think I can do a tiny cleanup of an edge case I was handling there which is now covered by @staabm's adaption because the explanation with non-empty-array felt very very familiar :) |
|
Yeah, sure :) |
herndlm
added a commit
to herndlm/phpstan-src
that referenced
this pull request
Mar 22, 2025
Is already covered by the adaption of phpstan#3895
|
--> #3896 |
ondrejmirtes
pushed a commit
that referenced
this pull request
Mar 22, 2025
Is already covered by the adaption of #3895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix regression mentioned in #3876 (comment)
followup to #3889