Add stream_socket_client’s stub
#3846
Open
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Mar 18, 2025
| * @param int $error_code | ||
| * @param-out int $error_code | ||
| * @param string $error_message | ||
| * @param-out string $error_message |
There was a problem hiding this comment.
What are these set to if the call does not fail?
There was a problem hiding this comment.
$error_code will be zero and $error_message an empty string.
$ php -r 'var_dump(stream_socket_client("udp://127.0.0.1:13", $errorCode, $errorMessage), $errorCode, $errorMessage);'
resource(5) of type (stream)
int(0)
string(0) ""EDIT it seems you can get those values even if the call fails: https://3v4l.org/TmSQQ
MatTheCat
force-pushed
the
stream_socket_client-stub
branch
from
5eb1e74 to
c5b80a7
Compare
|
@ondrejmirtes I’m not sure what changes you requested? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix phpstan/phpstan#12622