Do not report at attribute line #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janedbal
commented
Apr 16, 2025
| @@ -51,7 +52,7 @@ public function processNode(Node $node, Scope $scope): array | |||
| strtolower($deprecatedClass->getClassTypeDescription()), | |||
| $deprecatedClass->getName(), | |||
| $this->deprecatedClassHelper->getClassDeprecationDescription($deprecatedClass), | |||
| ))->identifier(sprintf('parameter.deprecated%s', $deprecatedClass->getClassTypeDescription()))->build(); | |||
| ))->identifier(sprintf('parameter.deprecated%s', $deprecatedClass->getClassTypeDescription()))->line($line)->build(); | |||
There was a problem hiding this comment.
Ideally, this should report at the parameter line, but that would be much bigger BC.
|
This would much better addressed in phpstan-src for rules executed on all nodes that can have attributes. And also on virtual nodes related to those nodes. And only for bleeding edge because it's a BC break. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe it is misleading to report at the first attribute line. Most visible when you inline ignore it. One real world example from our codebase:
This is minor BC, but I think moving few inline ignores is not that big deal. If you feel otherwise, we can use bleedingEdge.