Fix IntegrationPrinterWithPhpParserTest#255
Merged
Merged
Conversation
staabm
marked this pull request as ready for review
October 9, 2024 08:33
Contributor
Author
|
on my windows box for some reason I cannot fix CS here (creates a lot of unrelated changes). |
staabm
commented
Oct 9, 2024
| $this->indentSize = $size; | ||
|
|
||
| return NodeTraverser::STOP_TRAVERSAL; | ||
| return NodeVisitor::STOP_TRAVERSAL; |
Contributor
Author
There was a problem hiding this comment.
drive-by deprecation fix
Contributor
Author
|
in case we agree on this one, I can have a look at simple-downgrader 2.x |
Member
|
Awesome, thank you!
Yes please :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since PHPParser 5.3 this integration test fails.
it overlapps with a upstream implemenation of indentation-printing which was added with nikic/PHP-Parser@e50c67b
the PR removes the phpdoc-parser custom build indentation printer and re-uses the upstream indentation printer instead.