-
-
Notifications
You must be signed in to change notification settings - Fork 53
Composer repository builder should also make a phpBB4 only packages.json #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.3.x
Are you sure you want to change the base?
Conversation
I thought these changes weren't going to be needed. Not sure this will be ok. Like I said there is at least one extension that makes use of this data so not sure we want to break their stuff. |
Until some user submits an extension that is for phpBB3, and not compatible with phpBB4, yet they updated their composer installers to 2.0 for some reason. Then their extension could appear in phpBB4 forums as installable. |
This is the extension I'm referring to that is referencing the composer repo in Titania: https://github.com/BoardTools/upload/blob/develop-3.2.0/includes/sources/extensions_list.php#L18 These changes would essentially break this extension. Whether or not it is still active is another story. |
Ah I forgot about that extension. OK, here's an alternative approach then. Let's generate a second list that is for phpBB4 branch submissions only, in addition to the standard all extensions list. This way, the extension(s) currently using our repository list can continue unaffected, and in phpBB4's extension catalog we instead have it download its repository packages from the phpbb4 only branch, aka: |
0f6c80f
to
ae52a12
Compare
@DavidIQ and @marc1706 This PR would be in addition to phpbb/phpbb#6873
This PR updates the composer repo build for phpBB4’s extension catalog so that only extensions marked as supporting the phpBB 4 branch get included. Basically, it cuts down the risk of presenting extensions that aren’t submitted & validated for phpBB4 and could break boards.