Use storage in ads uploads #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMattPro
reviewed
Dec 25, 2024
iMattPro
reviewed
Dec 25, 2024
rubencm
force-pushed
the
storage
branch
3 times, most recently
from
8c7b872 to
5d35d50
Compare
rubencm
force-pushed
the
storage
branch
2 times, most recently
from
078bfd4 to
050c175
Compare
iMattPro
reviewed
Dec 28, 2024
migrations/v30x/m1_storage.php
Outdated
| continue; | ||
| } | ||
|
|
||
| $file_tracker->track_file('phpbb_ads', $file, filesize($dir . '/' . $file)); |
There was a problem hiding this comment.
This makes me wonder if the $file_tracker class should have track_files and untrack_files methods for handling multiple entries in 1 query?
There was a problem hiding this comment.
Yes, it can be updated to support more than one file.
I add it to the todo list
There was a problem hiding this comment.
Great! (Will be a lot less queries)
iMattPro
reviewed
Dec 31, 2024
| phpbb_ads_storage_banner: | ||
| path: /ads_download/{file} | ||
| defaults: | ||
| _controller: phpbb.ads.controller.banner:handle |
There was a problem hiding this comment.
We'll probably want to add stateless: true here eventually, re: https://github.com/phpbb/phpbb/compare/master...marc1706:phpbb:feature/stateless_sessions?expand=1
There was a problem hiding this comment.
Well, this can be done in the future, there is not even a pull request for this and can change in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.