refactor: reduce duplication in FileParser test cases #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract common test patterns into helper methods to eliminate repetitive boilerplate code: - parseCode(): combines FileParserFactory creation, parsing, and getting descriptions - evaluateRule(): combines Violations creation and rule evaluation This reduces 56 lines of duplicated code while maintaining test coverage and readability. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Remove redundant filePath parameter since all tests use the same 'relativePathName' value. This further reduces boilerplate and makes the helper method calls more concise. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
All tests use the same reason message, so hardcode it in the helper method to further simplify the API and reduce boilerplate. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
=========================================
Coverage 97.70% 97.70%
Complexity 615 615
=========================================
Files 80 80
Lines 1828 1828
=========================================
Hits 1786 1786
Misses 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
micheleorselli
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw from sonar cloud that this test has a lot of duplication:
https://sonarcloud.io/component_measures?metric=Duplications&id=phparkitect_arkitect
This is an attempt to reduce the duplication.
Extract common test patterns into helper methods to eliminate repetitive boilerplate code: