Skip to content

Create alternative to namespaceMatchesOneOfTheseNamespaces using splat instead of array #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Create alternative to namespaceMatchesOneOfTheseNamespaces using splat instead of array #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb43431
Replace `array` for `string ...`
Jul 26, 2023
aadf623
fixup!
hgraca Sep 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Analyzer/ClassDescription.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ public function namespaceMatches(string $pattern): bool
}

public function namespaceMatchesOneOfTheseNamespaces(array $classesToBeExcluded): bool
{
return $this->namespaceMatchesOneOfTheseNamespacesSplat(...$classesToBeExcluded);
}

public function namespaceMatchesOneOfTheseNamespacesSplat(string ...$classesToBeExcluded): bool
{
foreach ($classesToBeExcluded as $classToBeExcluded) {
if ($this->namespaceMatches($classToBeExcluded)) {
Expand Down
2 changes: 1 addition & 1 deletion src/Rules/ArchRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function __construct(

public function check(ClassDescription $classDescription, Violations $violations): void
{
if ($classDescription->namespaceMatchesOneOfTheseNamespaces($this->classesToBeExcluded)) {
if ($classDescription->namespaceMatchesOneOfTheseNamespacesSplat(...$this->classesToBeExcluded)) {
return;
}

Expand Down
7 changes: 7 additions & 0 deletions tests/Unit/Analyzer/ClassDescriptionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ public function test_should_return_true_if_there_class_is_in_namespace_array():
$this->assertTrue($cd->namespaceMatchesOneOfTheseNamespaces(['Fruit']));
}

public function test_should_return_true_if_there_class_is_in_namespace_list(): void
{
$cd = $this->builder->build();

$this->assertTrue($cd->namespaceMatchesOneOfTheseNamespacesSplat('Fruit', 'Banana'));
}

public function test_should_return_true_if_is_annotated_with(): void
{
$cd = $this->builder
Expand Down