Fix problem with sql_escape() introduced in 3.6.15 #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on phpList Discuss. There might be relevant details there: https://discuss.phplist.org/t/un-confirming-from-subscriber-profile-fails/10031/2 |
michield
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A change in release 3.6.15 to the
sql_escape()function incorrectly changes "0" to an empty string. That can cause a subsequent sql statement to fail due to trying to update an integer column with an empty string. Whether that is allowed depends on the sql mode.See this issue raised on the forum https://discuss.phplist.org/t/un-confirming-from-subscriber-profile-fails/10031/1
This is the commit in question, see the change to file public_html/lists/admin/mysqli.inc
f0443c3#diff-165411d48091a926d6eee355a541b83d13a57f8db5fb0c1b04f11170b2fe75b4
I think that a null value is the only special case that needs to be handled, not any
emptyvalue.Related Issue
Screenshots (if appropriate):