Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use php functions instead of imap functions #1072

Open
wants to merge 1 commit into
base: release-3.7.0
Choose a base branch
from

Conversation

bramley
Copy link
Contributor

@bramley bramley commented Feb 26, 2025

Description

The php-imap2 package used by the IMAP2 plugin doesn't replace the imap_qprint and imap_base64 functions correctly. To avoid any problems with using those functions the equivalent php functions quoted_printable_decode and base64_decode can be used instead.

Related Issue

#1063

Screenshots (if appropriate):

@michield michield changed the base branch from main to release-3.7.0 March 1, 2025 10:11
@michield
Copy link
Member

michield commented Mar 2, 2025

sorry, there's an annoying conflict due to me editing the /PULL_REQUEST_TEMPLATE.md

I've set the target branch to the release-1.7.0

If you update the conflict we can mark this ready to merge.

@bramley bramley force-pushed the imap2_missing_functions branch from 91398ab to e8b911b Compare March 2, 2025 12:11
@bramley bramley force-pushed the imap2_missing_functions branch from e8b911b to d2aee37 Compare March 2, 2025 12:15
@bramley
Copy link
Contributor Author

bramley commented Mar 2, 2025

I have rebased my changes onto the release-3.7.0 branch locally and force-pushed my change. That seems to have removed the conflict with PULL_REQUEST_TEMPLATE.

@michield michield self-requested a review March 2, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants