-
Notifications
You must be signed in to change notification settings - Fork 568
Update downloads content without full page reload #1312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Regression report for commit 0a43db5 is at https://web-php-regression-report-pr-1312.preview.thephp.foundation |
🚀 Preview for commit 0a43db5 can be found at https://web-php-pr-1312.preview.thephp.foundation |
If there are two changes, there are two asynchronous requests. If the first response arrives after the second, the instructions would not match the latest user selection. I'm not sure how to solve that. A mitigation could be to delay the request for some fraction of a second (what might be a good idea anyway). Also, error handling should be improved; logging to the console won't usually be seen by the user, but worse, if the server reponds with an error status, the script would try to go on. There should be a check for |
@cmb69 thanks!
What do you think about |
Interesting! I wasn't aware of that class, but it looks like a sensible way to solve the issue. |
Will this all still work if javascript is disabled too? |
If JS is not supported, it's just a normal form with an "Update Instructions" button. It might be better, though, to actually remove the button when JS is available (i.e. the concrete JS is supported by the browser), instead of relying on |
Co-authored-by: Shivam Mathur <[email protected]>
No description provided.