-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display thread tree as a tree #33
base: master
Are you sure you want to change the base?
Conversation
I much prefer the previous date format. As not a native speaker of English, AM and PM is terribly confusing (because the day starts with 12, not 0). And the US format of "month before day" without weekday is also not conductive to easily scanning the date. Also explicit timezone indicators are missing. |
What Tim said about the date and time formats.
I also think the date/times should stay in their own column. As it's much faster to read-search through.
We also don't usually do this odd prefixing (feat:?) of PRs and commits.
|
I would like to see this live first somewhere before merging, as I am unsure as to what the JavaScript would do even locally, as I'm quite worried that many defaults will just be the American date format and am/pm stuff. |
Instructions for running locally are in the |
I just checked what Chrome does here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Before:

After:

The message being viewed is too far down in the thread to be seen in the screenshot, but the current message is in bold and not a link so the context is clear.