Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display thread tree as a tree #33

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

jimwins
Copy link
Member

@jimwins jimwins commented Mar 23, 2025

Before:
Screenshot 2025-03-23 at 11 52 51 AM

After:
Screenshot 2025-03-23 at 11 53 04 AM

The message being viewed is too far down in the thread to be seen in the screenshot, but the current message is in bold and not a link so the context is clear.

@TimWolla
Copy link
Member

I much prefer the previous date format. As not a native speaker of English, AM and PM is terribly confusing (because the day starts with 12, not 0). And the US format of "month before day" without weekday is also not conductive to easily scanning the date. Also explicit timezone indicators are missing.

@php-pulls
Copy link

php-pulls commented Mar 23, 2025 via email

@jimwins jimwins changed the title feat: Display thread tree as a tree Display thread tree as a tree Mar 24, 2025
@jimwins
Copy link
Member Author

jimwins commented Mar 24, 2025

Without JavaScript:
Screenshot 2025-03-23 at 9 14 51 PM

With JavaScript (depending on browser configuration and timezone):
Screenshot 2025-03-23 at 9 15 06 PM

@derickr
Copy link
Member

derickr commented Mar 24, 2025

I would like to see this live first somewhere before merging, as I am unsure as to what the JavaScript would do even locally, as I'm quite worried that many defaults will just be the American date format and am/pm stuff.

@jimwins
Copy link
Member Author

jimwins commented Mar 24, 2025

Instructions for running locally are in the README.md. You can also see what your browser's default datetime format is by running new Date().toLocaleString() in the browser's JavaScript console.

@derickr
Copy link
Member

derickr commented Mar 24, 2025

I just checked what Chrome does here: 3/24/2025, 5:24:10 PM, and my locale is set to en_GB — which is obviously wrong. And I can't seem to change this setting anywhere.

Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants