Deprecate implicit default PGSQL connection #6790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
pgsql-deprecate-implicit-conn
branch
from
ccfd760 to
9e03cf9
Compare
Member
|
Needs a rebase |
Girgias
force-pushed
the
pgsql-deprecate-implicit-conn
branch
3 times, most recently
from
366924e to
459e298
Compare
nikic
approved these changes
Jul 9, 2021
Member
nikic
left a comment
nikic
left a comment
There was a problem hiding this comment.
LGTM, please don't forget the UPGRADING entry.
The DB connection should be provided in all cases as the first argument. The overloaded function signatures will be removed in the future. Warn about this change. Part of https://wiki.php.net/rfc/deprecations_php_8_1.
Girgias
force-pushed
the
pgsql-deprecate-implicit-conn
branch
from
98d61d4 to
ce7fe21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible implementation for https://wiki.php.net/rfc/deprecations_php_8_1#calling_overloaded_pgsql_functions_without_the_connection_argument