Skip to content

Deprecate $num_points parameter of image(open|filled)polygon #6789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cmb69 wants to merge 3 commits into from
Closed

Deprecate $num_points parameter of image(open|filled)polygon #6789

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e42f8e
Deprecate $num_points parameter of image(open|filled)polygon
cmb69 Mar 19, 2021
bcdb76b
Start message with upper case letter
cmb69 Mar 19, 2021
c00371b
Fix error message in test
cmb69 Mar 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ext/gd/gd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2673,6 +2673,8 @@ static void php_imagepolygon(INTERNAL_FUNCTION_PARAMETERS, int filled)
RETURN_THROWS();
}
NPOINTS /= 2;
} else {
php_error_docref(NULL, E_DEPRECATED, "using the $num_points parameter is deprecated");
}

im = php_gd_libgdimageptr_from_zval_p(IM);
Expand Down
5 changes: 4 additions & 1 deletion ext/gd/tests/bug55005.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ trycatch_dump(
fn () => imagepolygon($g, array(200,10, 200,100, 280,100), 2, $fgnd)
);
?>
--EXPECT--
--EXPECTF--
Deprecated: imagefilledpolygon(): using the $num_points parameter is deprecated in %s on line %d
!! [ValueError] imagefilledpolygon(): Argument #3 ($num_points_or_color) must be greater than or equal to 3

Deprecated: imagepolygon(): using the $num_points parameter is deprecated in %s on line %d
!! [ValueError] imagepolygon(): Argument #3 ($num_points_or_color) must be greater than or equal to 3