Rename zend_error_notify APIs to zend_observer_error* #6131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Sep 14, 2020
nikic
approved these changes
Sep 14, 2020
Member
nikic
left a comment
nikic
left a comment
There was a problem hiding this comment.
Looks fine to me, but maybe wait for Levi/Sammy to comment.
Contributor
Author
|
Merged in 1359a52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR #4555 introduced a new error notification callback API. After merging #5857 for PHP 8 as well, this PR moves the error notification API into
zend_observer.handzend_observer.c.This will produce a more consistent naming for future, where we provide a general observer API into different parts of PHP engine.
A soft goal would be that we can replace all parts of Dtrace support that are currently hardcoded into the engine using this general observer API provided by
zend_observer.hat some point in the future, so that dtrace can become an extension instead of being coupled into the engine./cc @morrisonlevi @SammyK