ticket-78385 an empty string in parse_url() return when question mark…

[fu22ybear]

… is the last

bug ticket 78385

[carusogabriel]

I know that this was report as a bug, but is there any change that this would break routers libraries or even frameworks?

[cmb69]

@carusogabriel looks so

[fu22ybear]

I missed this test files, they have to be updated too

[cmb69]

@Islam93, ah thanks! While I agree that it's more correct to report an empty query as empty string instead of null, this might break existing code.

[fu22ybear]

@cmb69, even it will not be merged, this issue was useful for me like first try to contribute to php :)

[nikic]

If nothing else, this change should be fine to merge into master.

[fu22ybear]

I'd prefer to do both in the same PR, to make sure that the behavior between these two cases stays consistent.

@nikic, ok, I will update current PR

[BenMorel]

Thank you! 👍