ext/opcache: zend_jit_resolve_tsrm_ls_cache_offsets() TEXTREL from ba…#22801
Closed
devnexen wants to merge 1 commit into
Closed
ext/opcache: zend_jit_resolve_tsrm_ls_cache_offsets() TEXTREL from ba…#22801devnexen wants to merge 1 commit into
devnexen wants to merge 1 commit into
Conversation
…re __tls_get_addr call. Fix phpGH-22693 The x86_64 General Dynamic TLS sequence called __tls_get_addr without @plt, which could emit a PC-relative relocation against the external symbol landing in read-only .text, producing a DT_TEXTREL and a linker warning about a possible runtime segfault. Routing the call through the PLT matches the x86-64 TLS ABI canonical sequence and the already correct i386 variant, without changing the emitted instruction bytes.
|
Goood |
arnaud-lb
approved these changes
Jul 20, 2026
arnaud-lb
left a comment
arnaud-lb
left a comment
Member
There was a problem hiding this comment.
This looks good to me! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…re __tls_get_addr call.
Fix GH-22693
The x86_64 General Dynamic TLS sequence called __tls_get_addr without @plt, which could emit a PC-relative relocation against the external symbol landing in read-only .text, producing a DT_TEXTREL and a linker warning about a possible runtime segfault. Routing the call through the PLT matches the x86-64 TLS ABI canonical sequence and the already correct i386 variant, without changing the emitted instruction bytes.