ext/Intl: Return PHP_INT_MIN as int from MessageFormatter::parse() on 64-bit#22131
Open
LamentXU123 wants to merge 1 commit into
Open
ext/Intl: Return PHP_INT_MIN as int from MessageFormatter::parse() on 64-bit#22131LamentXU123 wants to merge 1 commit into
LamentXU123 wants to merge 1 commit into
Conversation
devnexen
reviewed
May 22, 2026
| case Formattable::kInt64: | ||
| aInt64 = fargs[i].getInt64(); | ||
| if(aInt64 > ZEND_LONG_MAX || aInt64 < -ZEND_LONG_MAX) { | ||
| if(aInt64 > ZEND_LONG_MAX || aInt64 < ZEND_LONG_MIN) { |
Member
There was a problem hiding this comment.
Let's retarget this at master rather than PHP-8.4. It's a correctness fix, but the return type changes from float to int for PHP_INT_MIN, which is
user-observable, and I'd rather not ship that mid stable cycle for an edge case.
devnexen
reviewed
May 22, 2026
| @@ -0,0 +1,26 @@ | |||
| --TEST-- | |||
| Bug: MessageFormatter::parse() should preserve PHP_INT_MIN as int on 64-bit | |||
Member
There was a problem hiding this comment.
wrong format for description. Anyhow there is an argument for making a 32 bit version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning up.
-ZEND_LONG_MAXdoes not equals toZEND_LONG_MIN, because signed integer ranges are not symmetricin 64-bit
This makes -9,223,372,036,854,775,808 in MessageFormatter be degraded into float, but it could be an integer.
result in
But it should be
Reproduce
This is really a super super edge case. I don't even sure we should treat this as a bug fix or a refactor at this point. It really do come into my mind when I am looking at this code that I don't even think we need any NEWS or UPGRADING entry for this little fix. No similar bugs in the code base.