Empty some values of mysqli_get_charset()#21361
Open
kamil-tekiela wants to merge 2 commits intophp:masterfrom
Open
Empty some values of mysqli_get_charset()#21361kamil-tekiela wants to merge 2 commits intophp:masterfrom
kamil-tekiela wants to merge 2 commits intophp:masterfrom
Conversation
Girgias
approved these changes
Mar 6, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
I think the rationale makes sense. I'd add some comments for the properties you are adding that these are kept due to BC reasons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stateanddirwere already constants.commentwas undocumented and probably exposed unintentionally, as it doesn't report anything useful.numberis emptied because this value probably should not be exposed to the users. It can be misleading. The value represents the ID that PHP associates with that character set based on the IDs of the default collations on the server (which can change so it can never be relied upon).Before anyone asks about BC: this function never promised that the values wouldn't change. In the past, it has changed depending on which driver was used. I doubt anyone uses this useless function, but to keep the BC to minimum, the structure remains as documented in the PHP manual. Using the old values could even be considered a programming error as they haven't got a meaning outside of mysqlnd internals.
See #21338