Skip to content

Conversation

@arshidkv12
Copy link

@arshidkv12 arshidkv12 commented Jan 9, 2026

_zendi_try_convert_scalar_to_number() did not explicitly handle IS_REFERENCE operands, which could result in hitting the EMPTY_SWITCH_DEFAULT_CASE()` assertion when references reached the function.

#20873

@devnexen
Copy link
Member

devnexen commented Jan 9, 2026

is your PR actually fixing this particular issue or is it the wrong one ? completely unrelated. Beside I m not even sure the change is correct (or needed more precisely) actually, looking at the bigger picture. nevermind, the issue is actually #20873 but then your change, while passing the assertion, now gives a zendmm leak.

@arshidkv12
Copy link
Author

Sorry.. it is #20873. I will check the memory leak.

@arshidkv12
Copy link
Author

arshidkv12 commented Jan 9, 2026

Also fixes #20875.

@ndossche
Copy link
Member

ndossche commented Jan 9, 2026

This looks wrong, I don't understand the trick with Z_EXTRA, and I believe handling references in _zendi_try_convert_scalar_to_number is wrong. Note that the root cause of the issue is that a reference ends up in a TMP, which is not allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants