-
Notifications
You must be signed in to change notification settings - Fork 8k
Zend: handle IS_REFERENCE in _zendi_try_convert_scalar_to_number() #20876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
is your PR actually fixing this particular issue or is it the wrong one ? completely unrelated. |
|
Sorry.. it is #20873. I will check the memory leak. |
f2a51d9 to
282bdb6
Compare
|
Also fixes #20875. |
|
This looks wrong, I don't understand the trick with Z_EXTRA, and I believe handling references in _zendi_try_convert_scalar_to_number is wrong. Note that the root cause of the issue is that a reference ends up in a TMP, which is not allowed. |
_zendi_try_convert_scalar_to_number()did not explicitly handleIS_REFERENCE operands, which could result in hitting the EMPTY_SWITCH_DEFAULT_CASE()` assertion when references reached the function.#20873