Skip to content

Conversation

@dunglas
Copy link
Member

@dunglas dunglas commented Jan 6, 2026

clang is stricter than Visual Studio and requires an explicit include. This patch fixes building on Windows with clang-cl.

Details
 Zend\zend_call_stack.h(42,9): error: call to undeclared library function '_AddressOfReturnAddress' with type 'void *(void)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

   42 |         return _AddressOfReturnAddress();

      |                ^

Zend\zend_call_stack.h(42,9): note: include the header <intrin.h> or explicitly provide a declaration for '_AddressOfReturnAddress' 

@dunglas dunglas requested a review from arnaud-lb as a code owner January 6, 2026 10:21
@dunglas dunglas changed the base branch from master to PHP-8.4 January 6, 2026 10:22
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget NEWS.

@dunglas dunglas force-pushed the fix/windows-clang branch from 7610e95 to b02ddcc Compare January 6, 2026 13:49
Co-authored-by: Tim Düsterhus <[email protected]>
@dunglas dunglas force-pushed the fix/windows-clang branch from b02ddcc to a149b27 Compare January 6, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants