Fix timezone offset with seconds losing precision #20764
+74
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two issues: 1. The 'e' formatter doesn't output the seconds of the timezone even if it has seconds. 2. var_dump(), (array) cast, serialization, ... don't include the timezone second offset in the output. This means that, for example, serializing and then unserializing a date object loses the seconds of the timezone. This can be observed by comparing the output of getTimezone() for `$dt` vs the unserialized object in the provided test.
staabm
reviewed
Dec 23, 2025
Comment on lines
+800
to
+815
| case TIMELIB_ZONETYPE_OFFSET: { | ||
| int seconds = offset->offset % 60; | ||
| if (seconds == 0) { | ||
| length = slprintf(buffer, sizeof(buffer), "%c%02d:%02d", | ||
| ((offset->offset < 0) ? '-' : '+'), | ||
| abs(offset->offset / 3600), | ||
| abs((offset->offset % 3600) / 60) | ||
| ); | ||
| } else { | ||
| length = slprintf(buffer, sizeof(buffer), "%c%02d:%02d:%02d", | ||
| ((offset->offset < 0) ? '-' : '+'), | ||
| abs(offset->offset / 3600), | ||
| abs((offset->offset % 3600) / 60), | ||
| abs(seconds) | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
nit: these lines mix tabs and spaces
Member
Author
There was a problem hiding this comment.
Yeah this was already the case to align the switch case. It's a bit annoying to work with.
derickr
requested changes
Jan 13, 2026
Member
derickr
left a comment
derickr
left a comment
There was a problem hiding this comment.
I think I would like to see a test for a negative timezone offset as well, where seconds are present.
| int seconds = offset % 60; | ||
| size_t size; | ||
| const char *format; | ||
| if (seconds == 0) { |
Member
There was a problem hiding this comment.
nit: Extra new line between declarations and code please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues:
$dtvs the unserialized object in the provided test.