Zend: add const qualifiers for _zend_execute_data.func related uses #20263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstogov
reviewed
Oct 27, 2025
Comment on lines
-456
to
+458
| ZEND_API zend_function *zend_active_function_ex(const zend_execute_data *execute_data); | ||
| ZEND_API const zend_function *zend_active_function_ex(const zend_execute_data *execute_data); | ||
|
|
||
| static zend_always_inline zend_function *zend_active_function(void) | ||
| static zend_always_inline const zend_function *zend_active_function(void) |
There was a problem hiding this comment.
These changes may affect third-party extensions. Fixes are going to be trivial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit all over the place, as I was trying to see if we could make the
funcfield of_zend_execute_dataconstant.We cannot mainly due to trampolines, closures, and symbol table shenanigans due to
$http_response_header, but might as well merge the addedconstqualifiers in line with some of my other PRs.Happy to split this into multiple PRs if needed.