ext/phar: assert function are not passed NULL pointers #19356
Merged
+340
−461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
phar-spprintf-errors-refacto
branch
2 times, most recently
from
dabaffb to
c618444
Compare
nielsdos
requested changes
Aug 17, 2025
Girgias
force-pushed
the
phar-spprintf-errors-refacto
branch
from
c618444 to
6b0acde
Compare
|
CI failure is legit. It's probably because of code that was added/changed in the meantime. |
Yeah, but I wanted to extract some of the changes into a different PR which is now done in #20162 I'll rebase after that is merged and fix the NULL pointer attributes :) |
Girgias
force-pushed
the
phar-spprintf-errors-refacto
branch
from
6b0acde to
4e923ee
Compare
Girgias
force-pushed
the
phar-spprintf-errors-refacto
branch
from
4e923ee to
4892ece
Compare
nielsdos
approved these changes
Oct 16, 2025
|
Right, I forgot about them as I used them to debug my test failures. But those were just caused due to my OpenSSL not being able to verify the signature |
This simplifies some of the logic and makes the assumptions clear
Girgias
force-pushed
the
phar-spprintf-errors-refacto
branch
from
4892ece to
aa3d4d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies some of the logic and makes the assumptions clear