Implement GH-19249: http context - allow content to be a stream/resource #19267
Conversation
…source This may be useful for sending large chunks of data.
ext/standard/http_fopen_wrapper.c
Outdated
| *str_out = Z_STR_P(content); | ||
| return true; | ||
| } else if (Z_TYPE_P(content) == IS_RESOURCE) { | ||
| if ((php_stream_from_zval_no_verify(*stream_out, content))) { |
There was a problem hiding this comment.
| if ((php_stream_from_zval_no_verify(*stream_out, content))) { | |
| if (php_stream_from_zval_no_verify(*stream_out, content)) { |
There was a problem hiding this comment.
No, this is used to silence a compiler warning because php_stream_from_zval_no_verify expands to an assignment
| file_get_contents(): supplied resource is not a valid stream resource | ||
| file_get_contents(): supplied resource is not a valid stream resource |
There was a problem hiding this comment.
This is a confusing error message, as it is in the stream context the problem occurs really, not in the file_get_contents
ext/standard/http_fopen_wrapper.c
Outdated
| zend_off_t current_position = php_stream_tell(content_stream); | ||
| if (php_stream_seek(content_stream, 0, SEEK_END) < 0) { | ||
| return false; | ||
| } | ||
| zend_off_t end_position = php_stream_tell(content_stream); | ||
| if (php_stream_seek(content_stream, current_position, SEEK_SET) < 0) { | ||
| return false; | ||
| } | ||
| smart_str_append_unsigned(req_buf, end_position - current_position); |
There was a problem hiding this comment.
What about the non seekable streams?
I'm thinking that it might be better to use chunked encoding for such cases
There was a problem hiding this comment.
Alternatively you will need to fetch them to memory so it won't give much memory saving in this case but I guess files are bigger use case for this so it's probably better than nothing (considering that addition of chunked encoding support might be quite involved).
There was a problem hiding this comment.
I'll go with the "read to memory" solution as I believe that non-seekable streams are pretty rare in this context.
This may be useful for sending large chunks of data.