Skip to content

ext/standard: drop old smart_string headers #19233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

DanielEScherzer
Copy link
Member

Functionality was removed in PHP 7.2

Functionality was removed in PHP 7.2
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM

@DanielEScherzer DanielEScherzer merged commit 6141594 into php:master Jul 29, 2025
9 checks passed
@DanielEScherzer DanielEScherzer deleted the smart-string-headers branch July 29, 2025 14:57
@DanielEScherzer
Copy link
Member Author

CC @remicollet - if the builds for various (non-bundled) extensions for 8.5.0alpha3 fail because of an unknown header this might be why, solution is to update to the Zend/ header

@wyattoday
Copy link

Main branch of igbinary fails with this commit. https://github.com/igbinary/igbinary

@DanielEScherzer
Copy link
Member Author

Okay, I don't see any GitHub actions CI logs to help identify what files are failing to compile, but since https://github.com/igbinary/igbinary/blob/103c70222f1c0d3e139a74f1163007736d2a8a57/package.xml#L231-L235 indicates that it requires/supports PHP 7.0.0+, you'll need to put some condition on the inclusion to include the right header file based on the version

@wyattoday
Copy link

I'm not the owner of the igbinary project, but I'll make a PR tomorrow with the fix (if no one else gets to it first).

I was more just making a note of it for anyone wanting to use igbinary with PHP 8.5.0 alpha3 or newer and wondering why it doesn't compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants