Skip to content

SysV minor refactoring #19177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 28, 2025
Merged

SysV minor refactoring #19177

merged 6 commits into from
Jul 28, 2025

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jul 18, 2025

No description provided.

@Girgias Girgias marked this pull request as ready for review July 28, 2025 10:42
@Girgias Girgias requested a review from kocsismate as a code owner July 28, 2025 10:42
@Girgias Girgias requested a review from devnexen July 28, 2025 10:42
@@ -266,7 +266,7 @@ PHP_FUNCTION(sem_get)
/* }}} */

/* {{{ php_sysvsem_semop */
static void php_sysvsem_semop(INTERNAL_FUNCTION_PARAMETERS, int acquire)
static void php_sysvsem_semop(INTERNAL_FUNCTION_PARAMETERS, const bool acquire)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: not sure the const qualifier for acquire argument is really useful, it s just a bool passed by value.

@devnexen
Copy link
Member

changes make sense, I like the majority of them.

@Girgias Girgias merged commit f63a35d into php:master Jul 28, 2025
8 of 9 checks passed
@Girgias Girgias deleted the sysvshm-refacto branch July 28, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants