Update strlcat.c #18738
Open
Update strlcat.c #18738
+42
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor: Improve variable naming, loop clarity, and safety - Renamed variables for better clarity (e.g., `n` → `remaining`, `orig_dst`/`orig_src` for start pointers) - Optimized loops by removing unnecessary operations - Replaced `n != 0` with `remaining > 1` for clearer loop conditions - Added clearer comments and documentation for function behavior - Grouped related code blocks for better structure - Removed unnecessary temporary variables - Ensured null-termination (`\0`) to prevent buffer overflows - All performance characteristics and original algorithm logic preserved
|
see #18740 (comment) |
|
Is there much point in diverging from the upstream code here? If there are issues beyond style with it, then it's worth taking those upstream perhaps. And if it's functional changes, then keep in mind on platforms with strlcpy, then the behaviour diverges from that. |
NattyNarwhal
reviewed
Jun 3, 2025
| * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR | ||
| * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF | ||
| * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| * (Original OpenBSD license text preserved above) |
There was a problem hiding this comment.
The original license text was not preserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: Improve variable naming, loop clarity, and safety
n→remaining,orig_dst/orig_srcfor start pointers)n != 0withremaining > 1for clearer loop conditions\0) to prevent buffer overflows