Implement GH-15483: Use C23 memset_explicit() for ZEND_SECURE_ZERO() if available #18713
Conversation
…() if available
| #ifdef ZEND_WIN32 | ||
| #define ZEND_SECURE_ZERO(var, size) RtlSecureZeroMemory((var), (size)) | ||
| #elif defined(HAVE_MEMSET_EXPLICIT) | ||
| #define ZEND_SECURE_ZERO(var, size) memset_explicit((var), 0, (size)) |
There was a problem hiding this comment.
Should these be reordered? I would hope that Windows also gets memset_explicit() and then it should be the preferred one IMO.
There was a problem hiding this comment.
I don't think relying on the RTL is bad. Also: we're talking about Windows, from the company that can't even make a C99 compliant compiler nor preprocessor
There was a problem hiding this comment.
that can't even make a C99 compliant compiler nor preprocessor
I think this is due to VLA which have been removed from the standard since then?
Basically what I'm hoping for with the question is that we can do away with the ZEND_SECURE_ZERO macro one day and just use memset_explicit() directly everywhere.
There was a problem hiding this comment.
I think this is due to VLA which have been removed from the standard since then?
No, I was referring (non-limitative) to horrors like https://learn.microsoft.com/en-us/cpp/build/reference/experimental-preprocessor?view=msvc-170
Basically what I'm hoping for with the question is that we can do away with the ZEND_SECURE_ZERO macro one day and just use memset_explicit() directly everywhere.
I get that, but it would take years before we can bump to C23 anyway
No description provided.