Fix bug GH 18076#18317
Closed
carlosbuenosvinos wants to merge 3 commits into
Closed
Conversation
SakiTakamachi
approved these changes
Apr 16, 2025
Member
SakiTakamachi
left a comment
SakiTakamachi
left a comment
There was a problem hiding this comment.
Other than the small nit, looks good to me, thanks!
| ?> | ||
| --EXPECT-- | ||
| 05:59:21 | ||
| 18:14:48 No newline at end of file |
Member
There was a problem hiding this comment.
Could you add a newline at the end please?
SakiTakamachi
approved these changes
Apr 17, 2025
SakiTakamachi
added a commit
that referenced
this pull request
Apr 23, 2025
SakiTakamachi
added a commit
that referenced
this pull request
Apr 23, 2025
* PHP-8.3: [skip ci] NEWS for #18317
SakiTakamachi
added a commit
that referenced
this pull request
Apr 23, 2025
* PHP-8.4: [skip ci] NEWS for #18317
SakiTakamachi
added a commit
that referenced
this pull request
Apr 23, 2025
SakiTakamachi
added a commit
that referenced
this pull request
Apr 23, 2025
* PHP-8.4: [skip ci] NEWS for #18317
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #18076
An old bug fix introduced a double counting of the sun radial correction (15 minutes). -50 (-15 + -35). Because this factor is already added is double counting. To fix it, we need to remove 15 to the 50, then the -35.