Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext/date: Various minor refactorings #18044

Merged
merged 5 commits into from
Mar 28, 2025
Merged

ext/date: Various minor refactorings #18044

merged 5 commits into from
Mar 28, 2025
+41 −60

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Mar 13, 2025

Commits should be reviewed and merged individually.

@Girgias Girgias marked this pull request as ready for review March 13, 2025 22:50
@Girgias Girgias requested a review from derickr as a code owner March 13, 2025 22:50
derickr
derickr reviewed Mar 28, 2025
View reviewed changes
Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with all of them, except for:

8e01639

@Girgias
Copy link
Member Author

Girgias commented Mar 28, 2025

Rebased and dropped the variable scope reducing commit.

@Girgias Girgias merged commit 6ff9ca1 into php:master Mar 28, 2025
8 of 9 checks passed
@Girgias Girgias deleted the date-refactor branch March 28, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derickr derickr

Assignees
No one assigned
Labels
ABI break Extension: date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Girgias @derickr